Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interpolate #78

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Update interpolate #78

merged 5 commits into from
Jan 26, 2024

Conversation

rckirby
Copy link
Collaborator

@rckirby rckirby commented Jan 26, 2024

Firedrake have switched to a symbolic version of interpolate, and this PR avoids warnings and DTRT.

We'll need to switch back later to get rid of some future imports of interpolate once they make the switch

Copy link
Collaborator

@ScottMacLachlan ScottMacLachlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, aside from the NS demos issue. I see one more place where we have an old-style interpolate in a demo code that I'll fix now.

demos/navier_stokes/navier_stokes_demo.py Show resolved Hide resolved
Copy link
Collaborator

@ScottMacLachlan ScottMacLachlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rckirby rckirby merged commit df39b16 into master Jan 26, 2024
2 checks passed
@rckirby rckirby deleted the rckirby/switchinterpolation branch January 26, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants