Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Constant domains everywhere I can find them #79

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

ScottMacLachlan
Copy link
Collaborator

In #73 , we removed Constant for all of our time and dt objects, by introducing MeshConstant in irksome/tools.py. This finishes(?) that job, by removing other places where we assigning constants with domains, and using MeshConstant for all of these

Copy link
Collaborator

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Do we understand what needs to be a Constant versus having an attached mesh? Is it anything that might get recycled (which a butcher tableau might if you had a loop over stepping methods)?

@rckirby rckirby merged commit 8cf521e into master Jan 26, 2024
2 checks passed
@rckirby rckirby deleted the smaclachlan/NoDomain branch January 26, 2024 19:14
@ScottMacLachlan ScottMacLachlan restored the smaclachlan/NoDomain branch January 26, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants