Deploy Oct 9, 2024 (#5156)

[Nazım Can Altınova] [Tab selector 6] Get the real names of the extensions (#5132) [Steven P.] Add menu item to hide all tracks by type (#5106) [Julien Wajsberg] Use the new API of react (#5139) [Nazım Can Altınova] Do no persist the tooltips in flame graph and stack chart (#5147) [Nazım Can Altınova] [Tab selector 7] Sort the tabs by their thread activity scores (#5142) [Julien Wajsberg] Do not throw in the TrackPower tooltip when the user selects a selection with a zero duration (#5151) [Julien Wajsberg] When filtering markers, also match the full string when a colon is present (#5153) Thanks also to our localizers: de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fy-NL: Fjoerfoks ia: Melo46 it: Michele Rodaro nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Grk uk: Artem Polivanchuk zh-CN: Olvcpr423 zh-TW: Pin-guang Chen
firefox-devtools · Oct 9, 2024 · ced28a5 · ced28a5
2 parents 02a3f95 + 2da157f
commit ced28a5
Show file tree

Hide file tree

Showing 59 changed files with 1,336 additions and 758 deletions.
diff --git a/locales/de/app.ftl b/locales/de/app.ftl
@@ -749,6 +749,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Andere Screenshots-Tracks ausb
 TrackContextMenu--hide-track = „{ $trackName }“ verbergen
 TrackContextMenu--show-all-tracks = Alle Tracks anzeigen
 TrackContextMenu--show-local-tracks-in-process = Alle Tracks in diesem Prozess anzeigen
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Alle Spuren vom Typ „{ $type }“ ausblenden
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Alle passenden Tracks anzeigen

diff --git a/locales/el/app.ftl b/locales/el/app.ftl
@@ -768,6 +768,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Απόκρυψη άλλων κ
 TrackContextMenu--hide-track = Απόκρυψη του “{ $trackName }”
 TrackContextMenu--show-all-tracks = Εμφάνιση όλων των κομματιών
 TrackContextMenu--show-local-tracks-in-process = Εμφάνιση όλων των κομματιών σε αυτήν τη διεργασία
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Απόκρυψη όλων των ιχνών του τύπου «{ $type }»
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Εμφάνιση όλων των αντίστοιχων κομματιών

diff --git a/locales/en-GB/app.ftl b/locales/en-GB/app.ftl
@@ -773,6 +773,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Hide other Screenshots tracks
 TrackContextMenu--hide-track = Hide “{ $trackName }”
 TrackContextMenu--show-all-tracks = Show all tracks
 TrackContextMenu--show-local-tracks-in-process = Show all tracks in this process
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Hide all tracks of type “{ $type }”
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Show all matching tracks

diff --git a/locales/en-US/app.ftl b/locales/en-US/app.ftl
@@ -833,6 +833,11 @@ TrackContextMenu--hide-track = Hide “{ $trackName }”
 TrackContextMenu--show-all-tracks = Show all tracks
 TrackContextMenu--show-local-tracks-in-process = Show all tracks in this process
 
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Hide all tracks of type “{ $type }”
+
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Show all matching tracks

diff --git a/locales/es-CL/app.ftl b/locales/es-CL/app.ftl
@@ -703,6 +703,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Ocultar otras pistas de captur
 TrackContextMenu--hide-track = Ocultar “{ $trackName }”
 TrackContextMenu--show-all-tracks = Mostrar todas las pistas
 TrackContextMenu--show-local-tracks-in-process = Mostrar todas las pistas en este proceso
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Ocultar todas las pistas del tipo “{ $type }”
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Mostrar todas las pistas coincidentes

diff --git a/locales/fy-NL/app.ftl b/locales/fy-NL/app.ftl
@@ -773,6 +773,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Oare skermôfdruktracks fersto
 TrackContextMenu--hide-track = ‘{ $trackName }’ ferstopje
 TrackContextMenu--show-all-tracks = Alle tracks toane
 TrackContextMenu--show-local-tracks-in-process = Alle tracks yn dit proses toane
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Alle tracks fan it type ‘{ $type }’ ferstopje
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Alle oerienkommende tracks toane

diff --git a/locales/ia/app.ftl b/locales/ia/app.ftl
@@ -762,6 +762,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Celar altere tracias de instan
 TrackContextMenu--hide-track = Celar “{ $trackName }”
 TrackContextMenu--show-all-tracks = Monstrar tote le tracias
 TrackContextMenu--show-local-tracks-in-process = Monstrar tote le tracias in iste processo
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Celar tote la tracias de typo “{ $type }”
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Monstrar tote le tracias concordante

diff --git a/locales/it/app.ftl b/locales/it/app.ftl
@@ -691,6 +691,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Nascondi altre tracce Screensh
 TrackContextMenu--hide-track = Nascondi “{ $trackName } ”
 TrackContextMenu--show-all-tracks = Mostra tutte le tracce
 TrackContextMenu--show-local-tracks-in-process = Mostra tutte le tracce in questo processo
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Nascondi tutte le tracce di tipo “{ $type }”
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Mostra tutte le tracce corrispondenti

diff --git a/locales/nl/app.ftl b/locales/nl/app.ftl
@@ -773,6 +773,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Andere schermafdruktracks verb
 TrackContextMenu--hide-track = ‘{ $trackName }’ verbergen
 TrackContextMenu--show-all-tracks = Alle tracks tonen
 TrackContextMenu--show-local-tracks-in-process = Alle tracks in dit proces tonen
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Alle tracks van het type ‘{ $type }’ verbergen
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Alle overeenkomende tracks tonen

diff --git a/locales/pt-BR/app.ftl b/locales/pt-BR/app.ftl
@@ -702,6 +702,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Ocultar outras faixas de captu
 TrackContextMenu--hide-track = Ocultar “{ $trackName }”
 TrackContextMenu--show-all-tracks = Mostrar todas as faixas
 TrackContextMenu--show-local-tracks-in-process = Mostrar todas as faixas deste processo
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Ocultar todas as faixas do tipo “{ $type }”
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Mostrar todas as faixas correspondentes

diff --git a/locales/ru/app.ftl b/locales/ru/app.ftl
@@ -787,6 +787,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Скрыть другие тр
 TrackContextMenu--hide-track = Скрыть «{ $trackName }»
 TrackContextMenu--show-all-tracks = Показать все треки
 TrackContextMenu--show-local-tracks-in-process = Показать все треки в этом процессе
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Скрыть все треки для типа «{ $type }»
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Показать все совпадающие треки

diff --git a/locales/sv-SE/app.ftl b/locales/sv-SE/app.ftl
@@ -768,6 +768,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Dölj andra Skärmdump-spår
 TrackContextMenu--hide-track = Dölj "{ $trackName }"
 TrackContextMenu--show-all-tracks = Visa alla spår
 TrackContextMenu--show-local-tracks-in-process = Visa alla spår i denna process
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Dölja alla spår av typen "{ $type }"
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Visa alla matchande spår

diff --git a/locales/tr/app.ftl b/locales/tr/app.ftl
@@ -110,6 +110,8 @@ CallTreeSidebar--traced-running-time =
     .label = İzlenen çalışma süresi
 CallTreeSidebar--running-time =
     .label = Çalışma süresi
+CallTreeSidebar--running-samples =
+    .label = Çalışan örnekler
 CallTreeSidebar--running-size =
     .label = Çalışma boyutu
 CallTreeSidebar--categories = Kategoriler
@@ -578,6 +580,13 @@ TabBar--marker-table-tab = İşaret Tablosu
 TabBar--network-tab = Ağ
 TabBar--js-tracer-tab = JS İzleyici
 
+## TabSelectorMenu
+## This component is a context menu that's opened when you click on the root
+## range at the top left corner for profiler analysis view. It's used to switch
+## between tabs that were captured in the profile.
+
+TabSelectorMenu--all-tabs-and-windows = Tüm sekmeler ve pencereler
+
 ## TrackContextMenu
 ## This is used as a context menu for timeline to organize the tracks in the
 ## analysis UI.

diff --git a/locales/uk/app.ftl b/locales/uk/app.ftl
@@ -774,6 +774,10 @@ TrackContextMenu--hide-other-screenshots-tracks = Сховати доріжки
 TrackContextMenu--hide-track = Сховати “{ $trackName }”
 TrackContextMenu--show-all-tracks = Показати всі доріжки
 TrackContextMenu--show-local-tracks-in-process = Показати всі доріжки в цьому процесі
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = Приховати всі доріжки типу “{ $type }”
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = Показати всі відповідні доріжки

diff --git a/locales/zh-CN/app.ftl b/locales/zh-CN/app.ftl
@@ -686,6 +686,10 @@ TrackContextMenu--hide-other-screenshots-tracks = 隐藏其他快照轨
 TrackContextMenu--hide-track = 隐藏“{ $trackName }”
 TrackContextMenu--show-all-tracks = 显示所有轨道
 TrackContextMenu--show-local-tracks-in-process = 显示此进程中的所有轨道
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = 隐藏所有“{ $type }”类型的轨道
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = 显示所有匹配的轨道

diff --git a/locales/zh-TW/app.ftl b/locales/zh-TW/app.ftl
@@ -685,6 +685,10 @@ TrackContextMenu--hide-other-screenshots-tracks = 隱藏其他畫面擷圖軌
 TrackContextMenu--hide-track = 隱藏「{ $trackName }」
 TrackContextMenu--show-all-tracks = 顯示所有軌道
 TrackContextMenu--show-local-tracks-in-process = 顯示此處理程序當中的所有軌道
+# This is used as the context menu item to hide all tracks of the selected track's type.
+# Variables:
+#   $type (String) - Name of the type of selected track to hide.
+TrackContextMenu--hide-all-tracks-by-selected-track-type = 隱藏所有「{ $type }」類型的軌道
 # This is used in the tracks context menu as a button to show all the tracks
 # that match the search filter.
 TrackContextMenu--show-all-matching-tracks = 顯示所有符合的軌道

diff --git a/package.json b/package.json
@@ -58,22 +58,22 @@
     "@codemirror/lang-cpp": "^6.0.2",
     "@codemirror/lang-javascript": "^6.2.2",
     "@codemirror/lang-rust": "^6.0.1",
-    "@codemirror/language": "^6.10.2",
+    "@codemirror/language": "^6.10.3",
     "@codemirror/state": "^6.4.1",
-    "@codemirror/view": "^6.30.0",
+    "@codemirror/view": "^6.33.0",
     "@firefox-devtools/react-contextmenu": "^5.1.1",
     "@fluent/bundle": "^0.18.0",
     "@fluent/langneg": "^0.7.0",
     "@fluent/react": "^0.15.2",
     "@lezer/highlight": "^1.2.1",
-    "@tgwf/co2": "^0.16.0",
+    "@tgwf/co2": "^0.16.1",
     "array-move": "^3.0.1",
     "array-range": "^1.0.1",
     "clamp": "^1.0.1",
     "classnames": "^2.5.1",
     "common-tags": "^1.8.2",
     "copy-to-clipboard": "^3.3.3",
-    "core-js": "^3.38.0",
+    "core-js": "^3.38.1",
     "escape-string-regexp": "^4.0.0",
     "gecko-profiler-demangle": "^0.3.3",
     "idb": "^8.0.0",
@@ -87,7 +87,7 @@
     "query-string": "^9.1.0",
     "react": "^18.3.1",
     "react-dom": "^18.3.1",
-    "react-intersection-observer": "^9.13.0",
+    "react-intersection-observer": "^9.13.1",
     "react-redux": "^9.1.2",
     "react-splitter-layout": "^4.0.0",
     "react-transition-group": "^4.4.5",
@@ -100,40 +100,40 @@
     "workbox-window": "^7.1.0"
   },
   "devDependencies": {
-    "@babel/cli": "^7.24.8",
+    "@babel/cli": "^7.25.6",
     "@babel/core": "^7.25.2",
     "@babel/eslint-parser": "^7.25.1",
     "@babel/eslint-plugin": "^7.25.1",
     "@babel/plugin-proposal-class-properties": "^7.18.6",
-    "@babel/preset-env": "^7.25.3",
+    "@babel/preset-env": "^7.25.4",
     "@babel/preset-flow": "^7.24.7",
     "@babel/preset-react": "^7.24.7",
     "@testing-library/dom": "^10.4.0",
-    "@testing-library/jest-dom": "^6.4.8",
-    "@testing-library/react": "^16.0.0",
+    "@testing-library/jest-dom": "^6.5.0",
+    "@testing-library/react": "^16.0.1",
     "alex": "^11.0.1",
     "autoprefixer": "^10.4.20",
     "babel-jest": "^29.7.0",
-    "babel-loader": "^9.1.3",
+    "babel-loader": "^9.2.1",
     "babel-plugin-module-resolver": "^5.0.2",
-    "browserslist": "^4.23.3",
-    "caniuse-lite": "^1.0.30001640",
+    "browserslist": "^4.24.0",
+    "caniuse-lite": "^1.0.30001660",
     "circular-dependency-plugin": "^5.2.1",
     "codecov": "^3.8.3",
     "copy-webpack-plugin": "^12.0.2",
     "cross-env": "^7.0.3",
     "css-loader": "^7.1.2",
-    "cssnano": "^7.0.5",
+    "cssnano": "^7.0.6",
     "devtools-license-check": "^0.9.0",
-    "eslint": "^8.57.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-alias": "^1.1.2",
     "eslint-plugin-flowtype": "^8.0.3",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jest": "^28.8.0",
+    "eslint-plugin-import": "^2.30.0",
+    "eslint-plugin-jest": "^28.8.3",
     "eslint-plugin-jest-dom": "^5.4.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-react": "^7.35.0",
+    "eslint-plugin-react": "^7.35.2",
     "eslint-plugin-testing-library": "^6.3.0",
     "espree": "^10.1.0",
     "fake-indexeddb": "^6.0.0",
@@ -155,18 +155,18 @@
     "node-fetch": "^2.6.11",
     "npm-run-all": "^4.1.5",
     "open": "^10.1.0",
-    "postcss": "^8.4.41",
+    "postcss": "^8.4.45",
     "postcss-loader": "^8.1.1",
     "prettier": "^3.3.3",
     "raw-loader": "^4.0.2",
     "rimraf": "^5.0.10",
     "style-loader": "^4.0.0",
-    "stylelint": "^16.8.2",
+    "stylelint": "^16.9.0",
     "stylelint-config-idiomatic-order": "^10.0.0",
     "stylelint-config-standard": "^36.0.1",
     "webpack": "^5.94.0",
     "webpack-cli": "^5.1.4",
-    "webpack-dev-server": "^5.0.4",
+    "webpack-dev-server": "^5.1.0",
     "workbox-webpack-plugin": "^7.1.0",
     "yargs": "^17.7.2"
   },

diff --git a/src/actions/receive-profile.js b/src/actions/receive-profile.js
@@ -44,7 +44,10 @@ import {
   getSelectedTab,
   getTabFilter,
 } from 'firefox-profiler/selectors/url-state';
-import { getTabToThreadIndexesMap } from 'firefox-profiler/selectors/profile';
+import {
+  getTabToThreadIndexesMap,
+  getThreadActivityScores,
+} from 'firefox-profiler/selectors/profile';
 import {
   withHistoryReplaceStateAsync,
   withHistoryReplaceStateSync,
@@ -348,7 +351,11 @@ export function finalizeFullProfileView(
       // This is the case for the initial profile load.
       // We also get here if the URL info was ignored, for example if
       // respecting it would have caused all threads to become hidden.
-      hiddenTracks = computeDefaultHiddenTracks(tracksWithOrder, profile);
+      hiddenTracks = computeDefaultHiddenTracks(
+        tracksWithOrder,
+        profile,
+        getThreadActivityScores(getState())
+      );
     }
 
     const selectedThreadIndexes = initializeSelectedThreadIndex(
@@ -1804,7 +1811,11 @@ export function changeTabFilter(tabID: TabID | null): ThunkAction<void> {
       // This is the case for the initial profile load.
       // We also get here if the URL info was ignored, for example if
       // respecting it would have caused all threads to become hidden.
-      hiddenTracks = computeDefaultHiddenTracks(tracksWithOrder, profile);
+      hiddenTracks = computeDefaultHiddenTracks(
+        tracksWithOrder,
+        profile,
+        getThreadActivityScores(getState())
+      );
     }
 
     const selectedThreadIndexes = initializeSelectedThreadIndex(

diff --git a/src/components/marker-chart/Canvas.js b/src/components/marker-chart/Canvas.js
@@ -939,6 +939,7 @@ class MarkerChartCanvasImpl extends React.PureComponent<Props> {
         hitTest={this.hitTest}
         onMouseMove={this.onMouseMove}
         onMouseLeave={this.onMouseLeave}
+        stickyTooltips={true}
       />
     );
   }

diff --git a/src/components/shared/TabSelectorMenu.js b/src/components/shared/TabSelectorMenu.js
@@ -12,14 +12,14 @@ import { ContextMenu } from './ContextMenu';
 import explicitConnect from 'firefox-profiler/utils/connect';
 import { changeTabFilter } from 'firefox-profiler/actions/receive-profile';
 import { getTabFilter } from '../../selectors/url-state';
-import { getProfileFilterPageDataByTabID } from 'firefox-profiler/selectors/profile';
+import { getProfileFilterSortedPageData } from 'firefox-profiler/selectors/profile';
 
-import type { TabID, ProfileFilterPageData } from 'firefox-profiler/types';
+import type { TabID, SortedTabPageData } from 'firefox-profiler/types';
 import type { ConnectedProps } from 'firefox-profiler/utils/connect';
 
 type StateProps = {|
   +tabFilter: TabID | null,
-  +pageDataByTabID: Map<TabID, ProfileFilterPageData> | null,
+  +sortedPageData: SortedTabPageData | null,
 |};
 
 type DispatchProps = {|
@@ -36,9 +36,8 @@ class TabSelectorMenuImpl extends React.PureComponent<Props> {
   };
 
   renderTabSelectorMenuContents() {
-    const { pageDataByTabID, tabFilter } = this.props;
-    if (!pageDataByTabID || pageDataByTabID.size === 0) {
-      // There is no page data, return early.
+    const { sortedPageData, tabFilter } = this.props;
+    if (!sortedPageData || sortedPageData.length === 0) {
       return null;
     }
 
@@ -59,7 +58,7 @@ class TabSelectorMenuImpl extends React.PureComponent<Props> {
             All tabs and windows
           </Localized>
         </MenuItem>
-        {[...pageDataByTabID].map(([tabID, pageData]) => (
+        {sortedPageData.map(({ tabID, pageData }) => (
           <MenuItem
             key={tabID}
             onClick={this._handleClick}
@@ -92,7 +91,7 @@ export const TabSelectorMenu = explicitConnect<{||}, StateProps, DispatchProps>(
   {
     mapStateToProps: (state) => ({
       tabFilter: getTabFilter(state),
-      pageDataByTabID: getProfileFilterPageDataByTabID(state),
+      sortedPageData: getProfileFilterSortedPageData(state),
     }),
     mapDispatchToProps: {
       changeTabFilter,