Update JH_FRA cases to new spyro syntax #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmcdermo
reviewed
Sep 21, 2024
There was a problem hiding this comment.
@johodges These cases need to be run with the "master" branch. If I accept this PR, the validation guide would have "Validation/JH_FRA" as the branch name for these cases.
|
Good catch, I had meant to ask about that and forgot. I'll merge into my
master branch for staging and rerun on our cluster. I'll make sure to do
the same for the impinging jet cases before that pr.
|
|
It is always a good idea to actually build the validation guide and then look at the table in the back to make sure things look ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.