store parents in the header #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchris
commented
Sep 7, 2024
| @@ -465,3 +508,48 @@ export class WALStoreImpl extends BaseStoreImpl implements WALStore { | |||
| return this.gateway.destroy(this.url()); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I had trouble with the node module in the smoke test
There was a problem hiding this comment.
jchris
commented
Sep 7, 2024
| ).decodeMetaBlocks(bytes); | ||
| expect(decodedHeader).toBeDefined(); | ||
| expect(decodedHeader.cars).toBeDefined(); | ||
| expect(decodedHeader.cars[0].toString()).toEqual(cid.toString()); |
There was a problem hiding this comment.
how this is twice as long now... I bet we can flat it to one encoding
There was a problem hiding this comment.
I want the cid and parents to be in json, maybe we should just bring the cars up to the json also -- json means we don't need imports in our server code
|
Will make other connectors easier fireproof-storage/connect#7 (comment) |
jchris
commented
Sep 8, 2024
| @@ -46,6 +46,7 @@ export class ConnectPartyKit extends Connection { | |||
| const base64String = event.data; | |||
| const uint8ArrayBuffer = Base64.toUint8Array(base64String); | |||
| const eventBlock = await this.decodeEventBlock(uint8ArrayBuffer); | |||
| // there should be a callback in the MetaStore that we can call from places like this | |||
There was a problem hiding this comment.
@valorant-dhruv you'll need this when it comes time to listen to the websocket
|
I think this has what is needed to connect the meta with parent cid tracking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the encoding so all the connectors can support multi-writer easily.
It basically brings what was in the wire encoding for netlify / aws / partykit etc into the core.