Skip to content

Commit

Permalink
avinash feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-jamie committed May 3, 2024
1 parent 2b8e680 commit bea8707
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

## Bug Fixes
- Resolved the "duplicate column" error that would arise when the `facebook_ads__basic_ad_passthrough_metrics` variable included `reach` or `frequency`. `Reach` and `frequency` were included by default in the `stg_facebook_ads__basic_ad` model but will now only persist to downstream transform models if specified in the `facebook_ads__basic_ad_passthrough_metrics` variable.
- This error is now avoided by first [checking](https://github.com/fivetran/dbt_facebook_ads_source/blob/main/models/stg_facebook_ads__basic_ad.sql#L41-L45) if `reach` and `frequency` are included in `facebook_ads__basic_ad_passthrough_metrics` and only selecting the columns once if so.

## Under the Hood
- Updated the maintainer PR template to our most up-to-date standards.
Expand All @@ -29,10 +30,6 @@
- Updated tmp models to union source data using the `fivetran_utils.union_data` macro.
- To distinguish which source each field comes from, added `source_relation` column in each staging model and applied the `fivetran_utils.source_relation` macro.
- Updated tests to account for the new `source_relation` column.

# dbt_facebook_ads_source v0.UPDATE.UPDATE

## Under the Hood:
- Incorporated the new `fivetran_utils.drop_schemas_automation` macro into the end of each Buildkite integration test job.
- Updated the pull request [templates](/.github).

Expand Down

0 comments on commit bea8707

Please sign in to comment.