Skip to content

Commit

Permalink
Merge pull request #33 from fivetran/bug/creative-history-unique-test
Browse files Browse the repository at this point in the history
[Bug] Update Creative History Unique test
  • Loading branch information
fivetran-avinash authored Feb 7, 2024
2 parents 3733960 + eb799a8 commit cd5236f
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 20 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ dbt_modules/
logs/
.DS_Store

dbt_packages/
dbt_packages/
integration_tests/package-lock.yml
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_facebook_ads_source v0.7.2
[PR #33](https://github.com/fivetran/dbt_facebook_ads_source/pull/33) includes the following updates:

## 🧪 Test Updates 🧪
- Updated `stg_facebook_ads__creative_history` test in `stg_facebook_ads.yml` to test uniqueness on identifier `_fivetran_id`, since there are rare cases where `_fivetran_synced` and `creative_id` could hold the same value.

# dbt_facebook_ads_source v0.7.1

[PR #31](https://github.com/fivetran/dbt_facebook_ads_source/pull/31) includes the following updates:
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'facebook_ads_source'
version: '0.7.1'
version: '0.7.2'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
models:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'facebook_ads_source_integration_tests_2'
version: '0.7.1'
version: '0.7.2'
profile: 'integration_tests'
config-version: 2

Expand Down
3 changes: 1 addition & 2 deletions models/stg_facebook_ads.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,7 @@ models:
- dbt_utils.unique_combination_of_columns:
combination_of_columns:
- source_relation
- creative_id
- _fivetran_synced
- _fivetran_id
columns:
- name: source_relation
description: "{{ doc('source_relation') }}"
Expand Down

0 comments on commit cd5236f

Please sign in to comment.