Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #58

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Minor updates #58

merged 3 commits into from
Sep 14, 2023

Conversation

fivetran-reneeli
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature:
#50

This PR will result in the following new package version:

Wrapping into next batch of releases

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

  • updates the dbt-expectations dependency version in the README as there is now a v0.9.0
  • adds clarifying documentation in the DECISION LOG about why customers may see differences in metric aggregations across different grains

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • [n/a] dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Run the google ads transforms with this branch
You'll need to add the following to the packages.yml:

  - git: https://github.com/fivetran/dbt_google_ads_source.git
    revision: update_deps_versions
    warn-unpinned: false

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • [n/a] indexed within dbt_project.yml
    • [n/a] indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • [n/a] README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • [ n/a] Appropriate yml documentation has been added (if applicable)

❗ Special Updates for Ad Reporting ❗

To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:

  • this PR's package to true
  • Google Ads and Facebook Ads to true (if not already)
  • All other packages to falseS

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • [n/a] docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

packages.yml Outdated
# version: [">=0.9.0", "<0.10.0"]

- git: https://github.com/fivetran/dbt_google_ads_source.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to revert this change before merging

# dbt_google_ads v0.x.x

## Under the Hood:
- Updates the [dbt-expectations](https://github.com/calogica/dbt-expectations/releases) dependency in the [README](README.md) to the latest version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add this PR link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants