-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/file adjustments #67
Merged
+34
−28
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,33 @@ | ||
## PR Overview | ||
**This PR will address the following Issue/Feature:** | ||
|
||
**This PR will result in the following new package version:** | ||
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? --> | ||
|
||
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:** | ||
<!--- Copy/paste the CHANGELOG for this version below. --> | ||
|
||
## PR Checklist | ||
### Basic Validation | ||
Please acknowledge that you have successfully performed the following commands locally: | ||
- [ ] dbt run –full-refresh && dbt test | ||
- [ ] dbt run (if incremental models are present) | ||
|
||
Before marking this PR as "ready for review" the following have been applied: | ||
- [ ] The appropriate issue has been linked, tagged, and properly assigned | ||
- [ ] All necessary documentation and version upgrades have been applied | ||
- [ ] docs were regenerated (unless this PR does not include any code or yml updates) | ||
- [ ] BuildKite integration tests are passing | ||
- [ ] Detailed validation steps have been provided below | ||
|
||
### Detailed Validation | ||
Please share any and all of your validation steps: | ||
<!--- Provide the steps you took to validate your changes below. --> | ||
**Please provide your name and company** | ||
|
||
**Link the issue/feature request which this PR is meant to address** | ||
<!--- If an issue was not created, please create one first so we may discuss the PR prior to opening one. --> | ||
|
||
**Detail what changes this PR introduces and how this addresses the issue/feature request linked above.** | ||
|
||
**How did you validate the changes introduced within this PR?** | ||
|
||
**Which warehouse did you use to develop these changes?** | ||
|
||
**Did you update the CHANGELOG?** | ||
<!--- Please update the new package version’s CHANGELOG entry detailing the changes included in this PR. --> | ||
<!--- To select a checkbox you simply need to add an "x" with no spaces between the brackets (eg. [x] Yes). --> | ||
- [ ] Yes | ||
|
||
**Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)** | ||
<!--- The dbt_project.yml and the integration_tests/dbt_project.yml files contain the version number. Be sure to upgrade it accordingly --> | ||
<!--- To select a checkbox you simply need to add an "x" with no spaces between the brackets (eg. [x] Yes). --> | ||
- [ ] Yes | ||
|
||
**Provide an emoji that best describes your current mood** | ||
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) --> | ||
:dancer: | ||
|
||
**Feedback** | ||
|
||
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. | ||
|
||
**PR Template** | ||
- [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) | ||
|
||
- [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines in the gitignore are actually redundant. Since we already have
package-lock.yml
and.DS_Store
listed in the root directory gitignore, that means they will be ignored in all subdirectories as well.