feature/click-uri-updates

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: Issue #35 and Issue #30

This PR will result in the following new package version: v0.10.0

This will be a breaking change do to the addition of the new click_uri_type field and changes to the underlying click_uri field.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Breaking Changes

• The click_uri_type field has been added to the below mentioned models. This field allows users to differentiate which click uri type (text_ad or spotlight) is being used to populate the results of the click_uri field. Please be aware this field only supports text_ad or spotlight click uri types. If you are interested in this package supporting more click uri ad types, please let us know in this Feature Request.
  • stg_linkedin_ads__creative_history
  • linkedin_ads__creative_report
  • linkedin_ads__url_report

Bug Fixes (upstream dbt_linkedin_source change)

• The click_uri field has been adjusted to populate the results following a coalesce on the text_ad_landing_page, spotlight_landing_page, or click_uri fields. For more details refer to dbt_linkedin_source v0.10.0 release notes.
  • This change is in response to a LinkedIn Ads API and Fivetran LinkedIn Ads connector update which moved click_uri data to either the text_ad_landing_page or spotlight_landing_page fields depending on the creative type.

Documentation Updates

• The click_uri field documentation has been updated to reflect the updated state of the field.
• Included a new DECISIONLOG.md entry to highlight why it's possible metrics don't add up across different grains.

Under the Hood

• Updates to the linkedin_creative_history_data seed file to include the following new fields to ensure accurate data validation tests:
  • text_ad_landing_page
  • spotlight_landing_page

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• [n/a] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Please see successful validation test results below:

In addition to the validations succeeding above, I was able to confirm the new click_uri_type field is populating as expected. See the results below using our seed data.

• linkedin_ads__creative_report you can see for relevant creatives that the click_uri and click_uri_type fields are populating as expected.
  • 
• linkedin_ads__url_report you can see for all records that the click_uri and click_uri_type fields are populating as expected. In this screenshot we can see that the http://www.github.com click_uri is showing a null uri type. This is expected because as we know from the seed data, the http://www.github.com click_uri data is populated from the now deprecated click_uri field from the source package. This should appropriately not have a click_uri_type. Only the now supported text_ad and spotlight types should populate.
  • 

If you had to summarize this PR in an emoji, which would it be?

🔗

[fivetran-joemarkiewicz]

Will update before merge and release.

[fivetran-reneeli]

Looks good with just one question!

[fivetran-avinash]

@fivetran-joemarkiewicz PR approved, with standard reminder to update packages.yml

[fivetran-catfritz]

@fivetran-joemarkiewicz I was able to run the package updates and see that the click_uri coalesce is working properly, and the click_uri_type is populated correctly. I also tested the partitioning and source_relation logic, and that is compiling correctly. LGTM!

[fivetran-avinash]

One small suggestion but otherwise LGTM!