switch disable default config to enable default #40
+58
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: fivetran/dbt_marketo#41
This PR will result in the following new package version: v0.13.0
Breaking since this will enable these models for users who originally had these disabled by default. They will need to manually configure them to False is they wish to continue disabling them.Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Breaking Change
disable
toenable
for themarketo__enable_campaigns
andmarketo__enable_programs
variables. This will enable thestg_marketo__campaigns
andstg_marketo__program
models by default, but the Quickstart product will dynamically enable/disable these components. If you are not a Quickstart user nor are syncing the respectivecampaign
orprogram
tables, you must configure the variables accordingly. Refer to the README for details on how to do so.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Run without the relevant variables configured, then run with them set to False.
If you had to summarize this PR in an emoji, which would it be?
💃