Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch disable default config to enable default #40

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Dec 19, 2024

PR Overview

This PR will address the following Issue/Feature: fivetran/dbt_marketo#41

This PR will result in the following new package version: v0.13.0

Breaking since this will enable these models for users who originally had these disabled by default. They will need to manually configure them to False is they wish to continue disabling them.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Breaking Change

  • Changes the default enable/disable config from disable to enable for the marketo__enable_campaigns and marketo__enable_programs variables. This will enable the stg_marketo__campaigns and stg_marketo__program models by default, but the Quickstart product will dynamically enable/disable these components. If you are not a Quickstart user nor are syncing the respective campaign or program tables, you must configure the variables accordingly. Refer to the README for details on how to do so.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Run without the relevant variables configured, then run with them set to False.

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with just one small suggestion within the CHANGELOG

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants