remove account_id updates and regen docs

fivetran · Dec 2, 2024 · 1090c97 · 1090c97
1 parent 99a7aa5
commit 1090c97
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,9 +8,6 @@ For Netsuite2, [PR #149](https://github.com/fivetran/dbt_netsuite/pull/149) incl
   - When the `balance_sheet_transaction_detail_columns` and `income_statement_transaction_detail_columns` variables are used in the `netsuite2__balance_sheet` and `netsuite2__income_statement` models, all transactions are now included during incremental runs. This ensures no transactions are missed, aligning with the changes made in the `netsuite2__transaction_details` model.
   - We still recommend running `dbt --full-refresh` periodically to maintain data quality of the models.
 
-- Updated the `transactions_with_converted_amounts` join in the `netsuite2__transaction_details` model to include the `account_id`, ensuring accurate inclusion of transactions within the designated reporting period. This change resolves an issue where adjustments to the `account_id` at the source could introduce duplicates in the final model when using incremental strategies.
-  - A similar update was made to the joins in the `netsuite2__balance_sheet` and `netsuite2__income_statement` models to account for the `balance_sheet_transaction_detail_columns` and `income_statement_transaction_detail_columns` variables, ensuring consistency for users leveraging these options.
-
 ## Documentation
 - Updated dbt documentation definitions.
 

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/models/netsuite2/netsuite2__balance_sheet.sql b/models/netsuite2/netsuite2__balance_sheet.sql
@@ -257,7 +257,6 @@ balance_sheet as (
     left join transaction_details
         on transaction_details.transaction_id = transactions_with_converted_amounts.transaction_id
         and transaction_details.transaction_line_id = transactions_with_converted_amounts.transaction_line_id
-        and transaction_details.account_id = transactions_with_converted_amounts.account_id
 
         {% if var('netsuite2__multibook_accounting_enabled', false) %}
         and transaction_details.accounting_book_id = transactions_with_converted_amounts.accounting_book_id

diff --git a/models/netsuite2/netsuite2__income_statement.sql b/models/netsuite2/netsuite2__income_statement.sql
@@ -164,7 +164,6 @@ income_statement as (
     join transaction_details
         on transaction_details.transaction_id = transactions_with_converted_amounts.transaction_id
         and transaction_details.transaction_line_id = transactions_with_converted_amounts.transaction_line_id
-        and transaction_details.account_id = transactions_with_converted_amounts.account_id
 
         {% if var('netsuite2__multibook_accounting_enabled', false) %}
         and transaction_details.accounting_book_id = transactions_with_converted_amounts.accounting_book_id