Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DECISIONLOG re: null converted amounts #118

Conversation

fivetran-avinash
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature: [#

This PR will result in the following new package version:

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

📝 Documentation Update 📝

  • Updated DECISIONLOG with our reasoning for why we don't bring in future-facing transactions and leave the converted_amount in transaction details empty. (#115)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [NA] dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • -All necessary documentation and version upgrades have been applied
  • [NA] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Just a documentation update

@fivetran-avinash fivetran-avinash self-assigned this Apr 19, 2024
@fivetran-avinash fivetran-avinash changed the base branch from main to release/v0.13.0-apr-2024 April 19, 2024 01:29
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-avinash fivetran-avinash merged commit 26469f1 into release/v0.13.0-apr-2024 Apr 19, 2024
8 checks passed
@fivetran-avinash fivetran-avinash deleted the documentation/null-converted-amounts branch April 19, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants