Bugfix/too many partitions #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-catfritz
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
@fivetran-joemarkiewicz Gave this a test run, and all looks good here. Lgtm!
Co-authored-by: Avinash Kunnath <[email protected]>
fivetran-avinash
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
@fivetran-joemarkiewicz One comment but otherwise looks good to me!
docs/run_results.json
Outdated
There was a problem hiding this comment.
@fivetran-joemarkiewicz Think you want to remove this.
fivetran-joemarkiewicz
changed the base branch from
main
to
release-branch/v0.14.0
fivetran-avinash
merged commit bb3e777
into
release-branch/v0.14.0
7 of 9 checks passed
fivetran-avinash
added a commit
that referenced
this pull request
Sep 25, 2024
* Update customer and vendor joins * customer vendor joins * seeds, docs, test * schema bump * final fixes before PR review * tweak schema in integration tests * remove run results * PR review updates * update quickstart.yml * update run_models.sh * release-branch/v0.14.0 * Bugfix/too many partitions (#132) * bugfix/too-many-partitions * validation schema addition * docs regen and final changes before review * intermediate model conditional update * Apply suggestions from code review Co-authored-by: Avinash Kunnath <[email protected]> * removing conditional logic --------- Co-authored-by: Avinash Kunnath <[email protected]> * regen docs * release review --------- Co-authored-by: Jared Monger <[email protected]> Co-authored-by: Joe Markiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Issue #130
This PR will result in the following new package version:
v0.14.0This will be a breaking change for BigQuery users since this will adjust the partition grain. Therefore, we will want to mark this as a breaking change for all users.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See below the passing validation tests for both full refresh and incremental runs.