-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/subsidiary currency #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sspecacct field to stg_netsuite2__accounts table
switch to a different way of adding field sspecacct
Add sspecacct field as special_account_type_id to stg_netsuite2__accounts table
Merge upstream into lyra_sub_currency
This reverts commit af548a1.
…te_source into lyra_sub_currency
Adds subsidiary currency
fivetran-catfritz
force-pushed
the
feature/subsidiary-currency
branch
from
November 8, 2023 16:32
48d0914
to
b448fa7
Compare
fivetran-joemarkiewicz
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_netsuite#94
This PR will result in the following new package version:
v0.9.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🚨 Breaking Changes 🚨:
currency
field within thestg_netsuite2__subsidiaries
model.subsidiaries_pass_through_columns
variable and have includedcurrency
as a pass through column, you will experience a duplicate column error. We advise you remove thecurrency
field as a pass through columns to avoid runtime errors following this upgrade.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present)Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps: