Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/subsidiary currency #42

Merged
merged 17 commits into from
Dec 14, 2023
Merged

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Oct 27, 2023

PR Overview

This PR will address the following Issue/Feature:
fivetran/dbt_netsuite#94

This PR will result in the following new package version:

v0.9.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨:

  • Addition of the currency field within the stg_netsuite2__subsidiaries model.
    • This addition likely won't be breaking for a large number of users. However, if you are leveraging the subsidiaries_pass_through_columns variable and have included currency as a pass through column, you will experience a duplicate column error. We advise you remove the currency field as a pass through columns to avoid runtime errors following this upgrade.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • Column added used in related transform PR.

@fivetran-catfritz fivetran-catfritz self-assigned this Oct 27, 2023
@fivetran-catfritz fivetran-catfritz force-pushed the feature/subsidiary-currency branch from 48d0914 to b448fa7 Compare November 8, 2023 16:32
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fivetran-catfritz fivetran-catfritz merged commit cce5183 into main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants