-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add explicit datatype casts #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie these changes look great and work as expected when validating against Redshift and other warehouses. I do have one thought that we should consider overhauling the union_data if we're making this update anyway. Let me know your thoughts.
Co-authored-by: Joe Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions!
Co-authored-by: Renee Li <[email protected]>
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_qualtrics#10
This PR will result in the following new package version:
v0.3.0 - staging model results will be different for redshift users potentially (1 row instead of 0 for empty rows)
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Under the Hood
{{ dbt.type_boolean() }}
.qualtrics_union_data
macro to accommdate Redshift's treatment of empty tables.null
row for Redshift destinations.varchar
. This throws errors in dowstream transformations in thezendesk
package. The 1 row will ensure that Redshift will respect the package's datatype casts.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See data validation from fivetran/dbt_qualtrics#12
If you had to summarize this PR in an emoji, which would it be?
🟥