-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Net Income Adjustment is not applied for QBO instances with no revenue lines #145
Comments
Hey @brandonrf94 , good callout! I wonder if we can adjust the base of the CTE to account for this by pulling directly from the original intermediate model. Something like
Might do the trick in terms of bringing in those periods which are lacking revenue/expense lines. If you grab the compiled code from your target folder and substitute this CTE instead of the existing one, does that make a difference? |
How do I get the compiled code when using a quickstart? |
Ahh good call @brandonrf94 🤦🏽 . Let me try and get a pre-release branch ready for you to test these changes by early next week. We also are going to refactor the CTE to be more optimal computationally. Something like
will replace all the existing CTEs. |
Hi @brandonrf94 , just to give you an update, we are creating a pre-release branch for you to test and validate that these changes will work for you in Quickstart. We are hoping to have this released soon, and then we can sync with you on how to test this branch internally. |
Hi @fivetran-avinash - is this ready for testing? |
Hi @brandonrf94, I've created this pre-release for testing, but we are dealing with issues in our Quickstart deployment process. Once this is live on Quickstart, we'll let you know the process for testing this out. |
hi @fivetran-avinash - any luck here? |
Hi @brandonrf94, we are unfortunately still waiting for a resolution from our engineering team, there are a few dependencies that need to be resolved before this is ready to go live. We will be in touch when this is ready to try out in Quickstart. |
any luck @fivetran-avinash ? |
Hi @brandonrf94 , apologies for this taking so long. We had some hiccups with our release process and engineering couldn't pick up the branch, so we're cutting a new pre-release branch and will try and have it ready for testing in the coming days. |
Is there an existing issue for this?
Describe the issue
I have a QBO instance that has expenses logged and the net income adjustment is not coming through.
Following the code path for net income adjustment it looks like this code here: https://github.com/fivetran/dbt_quickbooks/blob/ea05fe5647b67fc04b3eb355856d5ca2254495ec/models/intermediate/int_quickbooks__retained_earnings.sql#L35C1-L42C3
assumes that QBO will have revenue and expenses to compute net income adjustment. But what about in cases where there is no revenue (or expenses) recognized yet - only one of the two or neither. The account should still be returned.
Relevant error log or model output
No response
Expected behavior
Net income adjustment is available regardless of revenue or expenses existing.
Possible solution
No response
dbt Project configurations
Most recent quickstart
Package versions
Most recent quickstart
What database are you using dbt with?
snowflake
How are you running this dbt package?
Fivetran Quickstart Data Model
dbt Version
Most recent quickstart
Additional Context
No response
Are you willing to open a PR to help address this issue?
The text was updated successfully, but these errors were encountered: