Releases/v0.6.latest

[fivetran-jamie]

PR Overview

This PR will address the following Issue/Feature:
#16 (also contains merged PR #20)

This PR will result in the following new package version:

v0.6.2

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

• Adjust the severity of the ad_account_id test in snapchat_ads__account_report to warn. This is required since Snapchat can hard-delete records from the history tables, but not from the reporting tables. This ensures that accurate statistics are being reported and production pipelines aren't failing. (PR #20)
  • Documents the above decision in the DECISIONLOG.md.

Under the Hood

• Updated the repo-maintainer PR template to our most up-to-date format.

Contributors

• @bthomson22 (PR #20)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Confirmed working by @bthomson22, but i also recreated the issue in a somewhat hacky way by

1. running the package as normal

2. updating the stg_snapchat_ads__ad_account_history to have null account IDs

3. running dbt run -m snapchat_ads__account_report without the code update

4. dbt test -m snapchat_ads__account_report -- produces failure without adjusting severity
   

5. dbt test again after updating the not_null test to be a warning (did so in Ad Reporting as well)
   

If you had to summarize this PR in an emoji, which would it be?

⚠️

[fivetran-joemarkiewicz]

LGTM

[fivetran-catfritz]

Should we also/do we need to change the combination_of_columns test to warn in case you have two deleted ad_account_ids in the same date_day and source_relation? Or would we want it to error out in that case? Same question for ad_reporting.

[fivetran-jamie]

due to our groupbys/aggregations, null accounts will get grouped together, so they shouldn't fail the combination_of_columns tests. do you think we should call this out?

[fivetran-catfritz]

Ahh I see... I think it would make sense to mention.