Feature/normalized billing model

[fivetran-reneeli]

to be completed

[fivetran-joemarkiewicz]

@fivetran-reneeli please see below for my comments and questions. Additionally, there are a few items that are leaving me a bit puzzled when reviewing the resulting data. I schedule some time for later today to discuss in more detail and determine next steps.

Before we meet, it would be great if you can review the questions and make any necessary changes.

[fivetran-joemarkiewicz]

The result from this code does not look accurate. We are seeing duplicates as a result of the header union and this is resulting in us double counting total amounts.

Additionally, using the above header_id as an example, I am confused how the line items achieve the total we are seeing. 🤔

[fivetran-reneeli]

model has been updated to remove duplicates

[fivetran-joemarkiewicz]

As of the latest updates there are still some duplicates. I was able to narrow it down to needing parentheses in this where clause to separate the index and not null clauses.

dbt_stripe/models/common_data_models/stripe__line_item_enhanced.sql

Lines 254 to 255 in b5d29fc

	where line_item_index = 1
	and discount_amount is not null or tax_amount is not null or fee_amount is not null or refund_amount is not null

[fivetran-joemarkiewicz]

@fivetran-reneeli thanks for making these updates! There were a few final comments I have, but I ended up consolidating and moving the changes to PR #82. This way there is a more clean PR (with less initial review comments) that we can share externally with the community and where they can add their own comments.

We will like close this out, but please review the minor changes between the branches to understand the updates I applied.

[fivetran-joemarkiewicz]

It looks like this test is failing at the moment

[fivetran-joemarkiewicz]

As of the latest updates there are still some duplicates. I was able to narrow it down to needing parentheses in this where clause to separate the index and not null clauses.

dbt_stripe/models/common_data_models/stripe__line_item_enhanced.sql

Lines 254 to 255 in b5d29fc

	where line_item_index = 1
	and discount_amount is not null or tax_amount is not null or fee_amount is not null or refund_amount is not null

[fivetran-joemarkiewicz]

Closing this as PR #82 will address this