Union Data V2 #178
Merged
Union Data V2 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
commented
Nov 21, 2024
packages.yml
Outdated
| version: [">=0.13.0", "<0.14.0"] | ||
| # - package: fivetran/zendesk_source | ||
| # version: [">=0.14.0", "<0.15.0"] | ||
| - git: https://github.com/fivetran/dbt_zendesk_source.git |
There was a problem hiding this comment.
switch later
There was a problem hiding this comment.
Bump for switch reminder before merge
There was a problem hiding this comment.
@fivetran-jamie just a few small comments before approving. Let me know your thoughts. Thanks!
packages.yml
Outdated
| version: [">=0.13.0", "<0.14.0"] | ||
| # - package: fivetran/zendesk_source | ||
| # version: [">=0.14.0", "<0.15.0"] | ||
| - git: https://github.com/fivetran/dbt_zendesk_source.git |
There was a problem hiding this comment.
Bump for switch reminder before merge
Co-authored-by: fivetran-catfritz <[email protected]>
…an/dbt_zendesk into feature/add-union-data-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#124
This will be merged in instead of #132
This PR will result in the following new package version:
v0.19.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validation tests all passed on our internal dataset (I added consistency ones for each end mode) EXCEPT for
sla_count_match(more below)I think the
sla_count_matchtest is actually misguided.The latest_sla window function on the source table doesn’t account for the limiting joins in this model.Also, test does not currently pass on prod! (the same exact 10 tickets fail). I've excluded the tickets for now to get everything passing 🤷♂️
If you had to summarize this PR in an emoji, which would it be?
👯♂️