Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/sla datatype updates #46

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Feb 7, 2024

PR Overview

This PR will address the following Issue/Feature: N/A This is for the downstream PR in dbt_zendesk

This PR will result in the following new package version: v0.11.0

This will be breaking as this has potential to change downstream metrics. In particular there may be some warehouses that treat the timezone timestamps differently. This update ensures all timestamps are non timezone.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Updated the following staging models to leverage the {{ dbt.type_timestamp() }} macro on timestamp fields in order to ensure timestamp with no timezone is used in downstream models.
    • stg_zendesk__ticket
    • stg_zendesk__ticket_comment
    • stg_zendesk__ticket_field_history
    • stg_zendesk__ticket_form_history
    • stg_zendesk__ticket_schedule
    • stg_zendesk__time_zone
    • stg_zendesk__user

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

I don't feel there are many more validation steps necessary for this PR. The validation of the dbt_zendesk PR should be sufficient.

If you had to summarize this PR in an emoji, which would it be?

⏲️

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review February 15, 2024 23:03
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just don't forget to link the PR in the changelog!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit ce4da6b into main Feb 21, 2024
7 checks passed
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants