Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: N/A This is for the downstream PR in dbt_zendesk
This PR will result in the following new package version:
v0.11.0
This will be breaking as this has potential to change downstream metrics. In particular there may be some warehouses that treat the timezone timestamps differently. This update ensures all timestamps are non timezone.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
{{ dbt.type_timestamp() }}
macro on timestamp fields in order to ensure timestamp with no timezone is used in downstream models.stg_zendesk__ticket
stg_zendesk__ticket_comment
stg_zendesk__ticket_field_history
stg_zendesk__ticket_form_history
stg_zendesk__ticket_schedule
stg_zendesk__time_zone
stg_zendesk__user
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
I don't feel there are many more validation steps necessary for this PR. The validation of the dbt_zendesk PR should be sufficient.
If you had to summarize this PR in an emoji, which would it be?
⏲️