-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add phone to stg_zendesk__user #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie this generally looks good but I just have one formatting suggestion and a general question for the Connector team before this will be good to approve.
Let me know if you have any questions.
Co-authored-by: Joe Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for release!
PR Overview
This PR will address the following Issue/Feature:
#39
This PR will result in the following new package version:
v0.11.1 -- also this change won't be reflected in the transform package models
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates
phone
field tostg_zendesk__user
.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
see hex link in height
If you had to summarize this PR in an emoji, which would it be?
☎️