Add passthrough columns for USER + ORG and add support for updated passthrough format for TICKET #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_zendesk#122 --> will need to update transform README after this
This PR will result in the following new package version:
v0.11.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates
USER
andORGANIZATION
.zendesk__user_passthrough_columns
andzendesk__organizations_passthrough_columns
variables, you can include custom columns from these source tables in their respective staging models. See README for more details on how to configure.TICKET
passthrough column variable,zendesk__ticket_passthrough_columns
.stg_zendesk__ticket
. Now, you can provide analias
andtransform_sql
clause to be applied to each field (see README for more details).PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
First, I ran with the new format across the board:
Everything passed
dbt run
dbt test
And I verified that the custom columns were present, filled with data, and properly aliased (if provided) in the WH
TICKET
USER
ORGANIZATION
I then reran, with
zendesk__ticket_passthrough_columns
using the old, currently employed formatEverything passed
dbt run
dbt test
In the WH, I confirmed that the staging ticket model had the custom columns, even if using the old variable format, which our macros are backwards compatible with
If you had to summarize this PR in an emoji, which would it be?
🛃