-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/group reserved kw union data v3 #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie I was able to confirm that this is not/no longer an issue on Postgres when running locally with the group
table retaining the reserved word naming convention.
I just have a request to make sure you remove the commented out Jinja logs are removed as well as a small wording suggestion update in the CHANGELOG. Otherwise this looks good to go!
Co-authored-by: Joe Markiewicz <[email protected]>
Co-authored-by: Joe Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
PR Overview
This PR will address the following Issue/Feature:
https://getdbt.slack.com/archives/C01D1R2JLLA/p1733513338340409
This PR will result in the following new package version:
v0.14.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
when searching for a relation, dbt found an approximate match
errors when running thestg_zendesk__group_tmp
model. We have updated theadapter.get_relation()
logic that was causing this error.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Recreated the issue in snowflake by creating a
group
table (selecting from thegroup_data
seed file)After applying the changes, confirmed that it works in Snowflake, BigQuery, and Redshift (@fivetran-joemarkiewicz will run on Postgres as I am having some terminal issues) when the table is named
group
, when the identifier var is used (ie to run ongroup_data
), and when the table is missing (I changed the identifier var value to something random likegroup_fake_alias
)If you had to summarize this PR in an emoji, which would it be?
🏂