Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADLS support #214

Closed
wants to merge 1 commit into from
Closed

Add ADLS support #214

wants to merge 1 commit into from

Conversation

fivetran-aleksandrboldyrev
Copy link
Contributor

No description provided.

beevital
beevital reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@beevital beevital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see here support for ADLS config fields.
There's no mapping for the new fields in resourceDestinationReadConfig or resourceDestinationCreateConfig methods.
It seems to me that you've forget to push some changes.

@fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev marked this pull request as draft October 31, 2023 10:53
@fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev deleted the T-562887_adls_support branch November 1, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beevital beevital beevital left review comments

Assignees

@beevital beevital

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fivetran-aleksandrboldyrev @beevital