Remove required table field for share point connector #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jovanmanojlovic
force-pushed
the
Remove_required_table_field_for_share_point_connector
branch
from
da96a3b to
d4ae7f7
Compare
beevital
reviewed
Sep 3, 2024
fivetran/common/fields.json
Outdated
| @@ -659,7 +659,8 @@ | |||
| "key_field": "", | |||
| "item_type": {}, | |||
| "description": { | |||
| "adobe_analytics": "The table name unique within the schema to which connector will sync the data. Required for connector creation." | |||
| "adobe_analytics": "The table name unique within the schema to which connector will sync the data. Required for connector creation.", | |||
| "share_point": "The table name within the schema to which the connector will sync the data." | |||
There was a problem hiding this comment.
how come we have it here? it's totally unrelated field for share_point.
fivetran/common/fields.json
Outdated
| @@ -10508,7 +10509,6 @@ | |||
| "kinesis": "Destination table. Table is permanent and cannot be changed after connection creation", | |||
| "s3": "Destination table. Table is permanent and cannot be changed after connection creation", | |||
| "sftp": "Destination table. Table is permanent and cannot be changed after connection creation", | |||
| "share_point": "Destination table. Table is permanent and cannot be changed after connection creation", | |||
There was a problem hiding this comment.
It should be still here, but we should handle it as optional field for share_point.
beevital
approved these changes
Sep 4, 2024
| @@ -328,10 +328,9 @@ func getDestinatonSchemaForConfig(serviceId, nameAttr, tableAttr, prefixAttr att | |||
| "schema": nameAttr.(types.String).ValueString(), | |||
| } | |||
| if common.GetDestinationSchemaFields()[service]["table"] { | |||
| if tableAttr.IsNull() { | |||
| return nil, fmt.Errorf("`destination_schema.table` field is required to create `%v` connector", service) | |||
| if !tableAttr.IsNull() { | |||
There was a problem hiding this comment.
We also should check if it is not empty string, just in case.
fivetran-jovanmanojlovic
deleted the
Remove_required_table_field_for_share_point_connector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.