Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for schema change handling for SAP connectors #360

Merged

Conversation

fivetran-jovanmanojlovic
Copy link
Contributor

No description provided.

@fivetran-jovanmanojlovic fivetran-jovanmanojlovic marked this pull request as ready for review September 12, 2024 12:09
Copy link
Collaborator

@beevital beevital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add additional check I've suggested.

@@ -94,7 +94,10 @@ func (d *ConnectorSchemaResourceModel) ReadFromResponse(response connectors.Conn
d.SchemasRaw = fivetrantypes.NewJsonSchemaValue(schemasJson)
}

d.SchemaChangeHandling = types.StringValue(response.Data.SchemaChangeHandling)
// SAP connectors will not accept schemaChangeHandling in request and will return ALLOW_COLUMNS as default
if d.SchemaChangeHandling.ValueString() != "" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check IsNull() || IsUnknown() as well

@fivetran-jovanmanojlovic fivetran-jovanmanojlovic merged commit 8e99df5 into main Sep 18, 2024
1 check failed
@fivetran-jovanmanojlovic fivetran-jovanmanojlovic deleted the Fix-for-schema-change-handling-for-SAP-connector branch September 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants