Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for client-provided room name #236

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Add support for client-provided room name #236

merged 1 commit into from
Feb 23, 2024

Conversation

petersalas
Copy link
Contributor

No description provided.

@petersalas petersalas requested a review from mdepinet February 22, 2024 23:05
mdepinet
mdepinet approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@mdepinet mdepinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the intermediate step we talked about :)

@petersalas petersalas merged commit e4f7ae7 into main Feb 23, 2024
2 checks passed
@petersalas petersalas deleted the psalas/room-name branch February 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdepinet mdepinet mdepinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petersalas @mdepinet