Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to seed training. #1085

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinzlocha
Copy link
Contributor

As we briefly discussed in #1075 I am adding the possibility to provide seed values.

@hgaiser
Copy link
Contributor

hgaiser commented Jul 25, 2019

I don't think this will work together with how we generate a random transformation:
https://github.com/fizyr/keras-retinanet/blob/master/keras_retinanet/utils/transform.py#L286

@martinzlocha
Copy link
Contributor Author

Sorry for the delay, hope its fine now.

@hgaiser
Copy link
Contributor

hgaiser commented Aug 12, 2019

It seems fine. Did you test it somehow to make sure the results were reproduced over two runs?

@de-vri-es
Copy link
Contributor

I'm not sure if this can work correctly with multithreaded workers running the generator. If variation in processing time changes the way work is distributed over threads, that would affect the random transforms.

With a single worker it should be fine I think. Might be worth adding a warning if multiple workers are used together with a seed.

@hgaiser
Copy link
Contributor

hgaiser commented Oct 3, 2019

With a single worker it should be fine I think. Might be worth adding a warning if multiple workers are used together with a seed.

@martinzlocha what do you think?

@martinzlocha
Copy link
Contributor Author

martinzlocha commented Oct 6, 2019

@hgaiser Yes I completely agree with the multi worker issue. Unfortunately I don't have the time right now to write proper tests and not sure when I will come back to this so it might be best to close the PR if its not a requested feature.

@hsahin hsahin changed the base branch from master to main June 17, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants