fix(local-command-bus): throw on send with unregistered command handler

fizzbuds · Nov 29, 2024 · f34eaf6 · f34eaf6
1 parent dd8bcbc
commit f34eaf6
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 17 deletions.
diff --git a/packages/ddd-toolkit/.changeset/slimy-queens-sniff.md b/packages/ddd-toolkit/.changeset/slimy-queens-sniff.md
@@ -0,0 +1,5 @@
+---
+'@fizzbuds/ddd-toolkit': minor
+---
+
+throw on send with unregistered command handler
diff --git a/packages/ddd-toolkit/src/command-bus/local-command-bus.spec.ts b/packages/ddd-toolkit/src/command-bus/local-command-bus.spec.ts
@@ -39,9 +39,9 @@ describe('LocalCommandBus', () => {
             describe('When send a foo command', () => {
                 it('Should log warning message', async () => {
                     const command = new FooCommand({ foo: 'bar' });
-                    await commandBus.send(command);
-
-                    expect(loggerMock.warn).toBeCalledWith(`No handler found for ${FooCommand.name}`);
+                    await expect(async () => await commandBus.send(command)).rejects.toThrow(
+                        `No handler found for ${FooCommand.name}`,
+                    );
                 });
             });
         });
@@ -64,7 +64,7 @@ describe('LocalCommandBus', () => {
                     const command = new FooCommand({ foo: 'bar' });
                     await commandBus.send(command);
 
-                    await waitFor(() => expect(FooHandlerMock).toBeCalledWith(command));
+                    await waitFor(() => expect(FooHandlerMock).toHaveBeenCalledWith(command));
                 });
             });
 
@@ -97,8 +97,8 @@ describe('LocalCommandBus', () => {
                         const command = new FooCommand({ foo: 'bar' });
                         await commandBus.send(command);
 
-                        await waitFor(() => expect(FooHandlerMock).toBeCalledWith(command));
-                        expect(BarHandlerMock).not.toBeCalled();
+                        await waitFor(() => expect(FooHandlerMock).toHaveBeenCalledWith(command));
+                        expect(BarHandlerMock).not.toHaveBeenCalled();
                     });
                 });
 
@@ -107,8 +107,8 @@ describe('LocalCommandBus', () => {
                         const command = new BarCommand({ foo: 'bar' });
                         await commandBus.send(command);
 
-                        expect(FooHandlerMock).not.toBeCalled();
-                        expect(BarHandlerMock).toBeCalledWith(command);
+                        expect(FooHandlerMock).not.toHaveBeenCalled();
+                        expect(BarHandlerMock).toHaveBeenCalledWith(command);
                     });
                 });
             });
@@ -135,21 +135,21 @@ describe('LocalCommandBus', () => {
 
                 it('handler should be called two times', async () => {
                     await waitFor(() => {
-                        expect(handlerMock).toBeCalledTimes(2);
+                        expect(handlerMock).toHaveBeenCalledTimes(2);
                     });
                 });
 
                 it('should not log error for failing handler', async () => {
                     await waitFor(() => {
-                        expect(handlerMock).toBeCalledTimes(2);
-                        expect(loggerMock.error).not.toBeCalled();
+                        expect(handlerMock).toHaveBeenCalledTimes(2);
+                        expect(loggerMock.error).not.toHaveBeenCalled();
                     });
                 });
 
                 it('should log one retry for failing handler', async () => {
                     await waitFor(() => {
-                        expect(loggerMock.warn).toBeCalledTimes(1);
-                        expect(loggerMock.warn).toBeCalledWith(
+                        expect(loggerMock.warn).toHaveBeenCalledTimes(1);
+                        expect(loggerMock.warn).toHaveBeenCalledWith(
                             expect.stringContaining(
                                 'FooCommandHandlerOk failed to handle FooCommand command. Attempt 1/3',
                             ),

diff --git a/packages/ddd-toolkit/src/command-bus/local-command-bus.ts b/packages/ddd-toolkit/src/command-bus/local-command-bus.ts
@@ -26,17 +26,15 @@ export class LocalCommandBus implements ICommandBus {
 
     public async send<C extends ICommand<unknown, unknown>>(command: C): Promise<void> {
         const handler = this.handlers[command.name] as ICommandHandler<C>;
-        if (!handler) {
-            this.logger.warn(`No handler found for ${command.name}`);
-            return;
-        }
+        if (!handler) throw new Error(`No handler found for ${command.name}`);
 
         void this.handleCommand(command, handler);
     }
 
     public async sendSync<C extends ICommand<unknown, unknown>>(command: C): Promise<C['_returnType']> {
         const handler = this.handlers[command.name] as ICommandHandler<C>;
         if (!handler) throw new Error(`No handler found for ${command.name}`);
+
         return await handler.handle(command);
     }