Transactional outbox #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtoselli
force-pushed
the
4-simple-transactional-outbox
branch
from
04159f3 to
74885dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 81.34% 84.01% +2.66%
==========================================
Files 15 16 +1
Lines 252 319 +67
Branches 47 51 +4
==========================================
+ Hits 205 268 +63
- Misses 47 51 +4 ☔ View full report in Codecov by Sentry. |
gtoselli
commented
Apr 3, 2024
| import { ISerializer } from './serializer.interface'; | ||
| import { merge } from 'lodash'; | ||
| import { DuplicatedIdError, OptimisticLockError, RepoHookError } from '../errors'; | ||
| import { ILogger } from '../logger'; | ||
| import { IInit } from '../init.interface'; | ||
| import { IEvent } from '../event-bus/event-bus.interface'; | ||
| import { IOutbox } from '../outbox/outbox.interface'; | ||
|
|
||
| export interface IAggregateRepo<A> { | ||
| // TODO add id as a generic type |
gtoselli
commented
Apr 3, 2024
|
|
||
| export interface IAggregateRepo<A> { | ||
| // TODO add id as a generic type | ||
| getById: (id: string) => Promise<WithVersion<A> | null>; | ||
| save: (aggregate: A) => Promise<void>; | ||
| } | ||
|
|
||
| export interface IAggregateRepoWithOutbox<A> extends IAggregateRepo<A> { | ||
| saveAndPublish: (aggregate: A, eventsToBePublished?: IEvent<unknown>[]) => Promise<void>; |
There was a problem hiding this comment.
rename in eventsToPublish
gtoselli
commented
Apr 3, 2024
| @@ -21,15 +27,19 @@ type WithOptionalVersion<T> = T & { __version?: number }; | |||
| // TODO probably we should create a dedicated interface whit like DocumentWithIdAndTimestamps | |||
| const MONGODB_UNIQUE_INDEX_CONSTRAINT_ERROR = 11000; | |||
|
|
|||
| export class MongoAggregateRepo<A, AM extends DocumentWithId> implements IAggregateRepo<A>, IInit { | |||
| export class MongoAggregateRepo<A, AM extends DocumentWithId> | |||
There was a problem hiding this comment.
create another class
gtoselli
commented
Apr 3, 2024
| status: 'scheduled' | 'processing' | 'published'; | ||
| publishedAt?: Date; | ||
| contextName?: string; | ||
| locked?: boolean; |
gtoselli
commented
Apr 3, 2024
| locked?: boolean; | ||
| }; | ||
|
|
||
| export class MongoOutbox implements IOutbox { |
gtoselli
commented
Apr 3, 2024
| return Object.values(insertedIds).map((id) => id.toString()); | ||
| } | ||
|
|
||
| public async publishEvents(eventIds: string[]): Promise<void> { |
lucagiove
force-pushed
the
4-simple-transactional-outbox
branch
from
74885dc to
8479ac9
Compare
|
Repo with Outbox has a dedicated class that extends base MongoAggregateRepo class |
gtoselli
force-pushed
the
4-simple-transactional-outbox
branch
from
cb8930d to
fd4bb78
Compare
gtoselli
force-pushed
the
4-simple-transactional-outbox
branch
from
0276534 to
c48497c
Compare
lucagiove
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.