Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto material plugin v1 #1247

Merged
merged 1 commit into from
Dec 10, 2024
Merged

crypto material plugin v1 #1247

merged 1 commit into from
Dec 10, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 20, 2024

@jstucke jstucke requested a review from maringuu August 20, 2024 14:26
@jstucke jstucke self-assigned this Aug 20, 2024
@jstucke jstucke force-pushed the crypto-material-pluginv1 branch 3 times, most recently from 48caaab to e9d5a97 Compare August 21, 2024 08:29
@jstucke jstucke force-pushed the crypto-material-pluginv1 branch from e9d5a97 to e33954f Compare December 9, 2024 13:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (ad4d6d8) to head (2ddfed6).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...ns/analysis/crypto_material/internal/key_parser.py 95.45% 2 Missing ⚠️
...s/analysis/crypto_material/code/crypto_material.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   92.23%   91.84%   -0.39%     
==========================================
  Files         379      378       -1     
  Lines       23188    20967    -2221     
==========================================
- Hits        21387    19257    -2130     
+ Misses       1801     1710      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jstucke jstucke force-pushed the crypto-material-pluginv1 branch from e33954f to 2ddfed6 Compare December 10, 2024 14:35
@jstucke jstucke merged commit 2aa83a0 into master Dec 10, 2024
10 checks passed
@jstucke jstucke deleted the crypto-material-pluginv1 branch December 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants