-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release scripts #5
Conversation
jstucke
commented
Aug 14, 2024
- added release scripts and dependencies
- updated metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor nits.
pyproject.toml
Outdated
@@ -9,10 +9,20 @@ build-backend = "setuptools.build_meta" | |||
[project] | |||
name = "entropython" | |||
version = "1.1.0" | |||
readme = "README.md" | |||
description = "A Python module for efficient calculation of Shannon byte entropy based on Rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a full stop?
_build-wheels.sh
Outdated
@@ -0,0 +1,21 @@ | |||
#!/bin/bash | |||
set -ex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, I also tend to set -u
(just for good practice, not going to change anything here). Helped me quite often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
f85e9ed
to
4046d92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks! :)