Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release scripts #5

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Release scripts #5

merged 2 commits into from
Nov 13, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 14, 2024

  • added release scripts and dependencies
  • updated metadata

@jstucke jstucke requested a review from vobst August 14, 2024 12:10
@jstucke jstucke self-assigned this Aug 14, 2024
Copy link

@vobst vobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor nits.

pyproject.toml Outdated
@@ -9,10 +9,20 @@ build-backend = "setuptools.build_meta"
[project]
name = "entropython"
version = "1.1.0"
readme = "README.md"
description = "A Python module for efficient calculation of Shannon byte entropy based on Rust"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a full stop?

_build-wheels.sh Outdated
@@ -0,0 +1,21 @@
#!/bin/bash
set -ex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, I also tend to set -u (just for good practice, not going to change anything here). Helped me quite often.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@jstucke jstucke requested a review from vobst August 15, 2024 09:00
Copy link

@vobst vobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks! :)

@jstucke jstucke merged commit 8335698 into main Nov 13, 2024
7 checks passed
@jstucke jstucke deleted the release-scripts branch November 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants