[flang1] Fix the issue with contiguous dummy argument arrays (#1426) #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawosm-arm
reviewed
Nov 5, 2023
When array dummy arguments are marked as contiguous,compiler need to generate and pass sequential copy of formal arguments. This issue is fixed as part of this commit.
shivaramaarao
force-pushed
the
shivaram_1426
branch
from
0054c1d to
de6253e
Compare
semfunc.c changes are not required. The change was to do runtime is_contiguous check for dummy arguements instead of compile time check. If the compiler is making sure that the array passed are contiguous those changes are not needed. |
pawosm-arm
approved these changes
Nov 6, 2023
bryanpkc
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM, though I agree with @pawosm-arm that both test/f90_correct/src/c_cont01.c and test/f90_correct/src/cont01.f90 should be formatted to be consistent with the rest of the code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When array dummy arguments are marked with contiguous attribute, the compiler need to generate and pass sequential copy of formal arguments.
This issue is fixed as part of this commit.