Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): allow specifying storage class for PutObject #2440

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

syhpoon
Copy link
Contributor

@syhpoon syhpoon commented Feb 11, 2025

Allow configuring S3 check to use a non-default storage class for PutObject.
The storage class is specified as a raw string to allow for new values in the future as well as non-AWS custom storage classes.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@adityathebe
Copy link
Member

@syhpoon Can you also run make resources to generate the CRDs

@syhpoon syhpoon force-pushed the syhpoon/s3-storage-class branch from 75b89bf to ee2511e Compare February 12, 2025 15:10
@syhpoon syhpoon force-pushed the syhpoon/s3-storage-class branch from ee2511e to c78d4fe Compare February 12, 2025 15:15
@syhpoon
Copy link
Contributor Author

syhpoon commented Feb 12, 2025

@syhpoon Can you also run make resources to generate the CRDs

@adityathebe done!

@moshloop moshloop enabled auto-merge (rebase) February 12, 2025 18:19
@moshloop moshloop merged commit 1c3e8ea into flanksource:master Feb 12, 2025
15 of 16 checks passed
@syhpoon syhpoon deleted the syhpoon/s3-storage-class branch February 12, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants