Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2285-Catalog-Detail-Page---Add-pagination #2329

Merged
merged 10 commits into from
Oct 16, 2024
Merged

2285-Catalog-Detail-Page---Add-pagination #2329

merged 10 commits into from
Oct 16, 2024

Conversation

mainawycliffe
Copy link
Contributor

Fixes #2285

@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
aws-preview ✅ Ready (Inspect) Visit Preview Oct 16, 2024 1:25pm
flanksource-ui ✅ Ready (Inspect) Visit Preview Oct 16, 2024 1:25pm

@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 6d68dd6
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/670fbc6cbc02000008c38675
😎 Deploy Preview https://deploy-preview-2329--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 6d68dd6
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/670fbc6c4b48fd00081f9682
😎 Deploy Preview https://deploy-preview-2329--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 6d68dd6
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/670fbc6c4b48fd00081f9680
😎 Deploy Preview https://deploy-preview-2329--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 51c01b4 to b8d9d48 Compare October 4, 2024 13:19
@mainawycliffe mainawycliffe mentioned this pull request Oct 4, 2024
Merged
@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from b859bec to 4c05488 Compare October 4, 2024 17:55
@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 4c05488 to 50f8d87 Compare October 4, 2024 18:33
@mainawycliffe mainawycliffe marked this pull request as draft October 4, 2024 19:06
@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 50f8d87 to 21cc317 Compare October 7, 2024 16:27
@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 21cc317 to 62fa74d Compare October 8, 2024 19:22
@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 62fa74d to 917d996 Compare October 8, 2024 19:30
@mainawycliffe mainawycliffe marked this pull request as ready for review October 9, 2024 06:35
@moshloop
Copy link
Member

@mainawycliffe

  • Can we disable hiding and drag to group on these tables as it doesn't work,
  • for relationships table can we set max width for expand column, and reduce the padding - the rows should be same height as other tables

@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 60bc463 to 79f84d3 Compare October 11, 2024 19:32
@mainawycliffe
feat: add support for pagination for configs list
0dba394
@mainawycliffe
feat: enable grouping and fix issue around expanded
0399bb2 
fix: fix expand initial state issues
@mainawycliffe
fix: improve mrt by disabling dragging and dropping columns and hidin…
527709c 
…g the

column menu button

fix: prevent mrt from dragging and drop columns

chore: improve table
@mainawycliffe
refactor: switch to MRT for Config Insights Table
e215ff7 
Fixes #2285
@mainawycliffe
refactor: use mantime react table for config changes
fb7364a 
Fixes #2285

fix: fix issue with config changes  table
@mainawycliffe
refactor: for playbooks, use mantime react table
930f128 
Fixes #2285

fix: fix props issue for playbooks

fix: fix issues with playbook runs
@mainawycliffe
refactor: use MRT for config relationships
bef6bce 
Fixes #2285

fix: typescript error

refactor: move to MRT for tables for configs

Fixes  #2285

fix: fix empty text for default grouping value
@mainawycliffe
fix: fix issue affecting sorting in MRT tables
2bc45e3
@mainawycliffe
fix: fix issue with config tables
0322123
@mainawycliffe mainawycliffe force-pushed the 2285-Catalog-Detail-Page---Add-pagination branch from 79f84d3 to 0322123 Compare October 14, 2024 10:41
@moshloop moshloop enabled auto-merge (squash) October 16, 2024 13:16
@moshloop moshloop merged commit c6f1c9c into main Oct 16, 2024
12 of 17 checks passed
@moshloop moshloop deleted the 2285-Catalog-Detail-Page---Add-pagination branch October 16, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catalog Detail Page - Add pagination
2 participants
@mainawycliffe @moshloop