fix: fix sorting and paging not working on config changes #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe it doesn't look like the page size is included in the first request |
mainawycliffe
force-pushed
the
fix-sorting-changes-not-working
branch
from
e786a9d to
6fdce32
Compare
|
@mainawycliffe can we default the sort on changes to be by last seen ? |
|
@moshloop the backend only allows name, change_type, summary, source, created_at, count for sorting |
|
@mainawycliffe - created_at is last seen - before it was sorted by most recent, and now its unsorted which doesn't make sense when looking at history |
chore: default to created at when no sorting is set
mainawycliffe
force-pushed
the
fix-sorting-changes-not-working
branch
from
6fdce32 to
c9cef50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.