feat: Notification silence new fields #2447
Open
+94
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@moshloop we now have silences with no time bounds. I think we need to convey that here.
|
adityathebe
changed the title
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@moshloop what form input type should we use for multiple resource selectors for the silence? |
moshloop
reviewed
Jan 27, 2025
adityathebe
force-pushed
the
feat/notification-silence-new-fields
branch
from
f4948c4 to
ead531a
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
src/components/Notifications/SilenceNotificationForm/NotificationSilenceForm.tsx
Outdated
Show resolved
Hide resolved
adityathebe
force-pushed
the
feat/notification-silence-new-fields
branch
from
ead531a to
17134f4
Compare
adityathebe
force-pushed
the
feat/notification-silence-new-fields
branch
from
17134f4 to
2030000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2423
resolves: #2449