Fix for MutatingWebhook: Snapshots not being added (#471)

flant · Jul 12, 2023 · 337f676 · 337f676
1 parent 97a2b07
commit 337f676
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/pkg/hook/config/config_v1.go b/pkg/hook/config/config_v1.go
@@ -296,6 +296,15 @@ func (cv1 *HookConfigV1) ConvertAndCheck(c *HookConfig) (err error) {
 	}
 	c.KubernetesValidating = newValidating
 
+	newMutating := make([]MutatingConfig, 0)
+	for _, cfg := range c.KubernetesMutating {
+		if snapshots, ok := groupSnapshots[cfg.Group]; ok {
+			cfg.IncludeSnapshotsFrom = MergeArrays(cfg.IncludeSnapshotsFrom, snapshots)
+		}
+		newMutating = append(newMutating, cfg)
+	}
+	c.KubernetesMutating = newMutating
+
 	newConversion := make([]ConversionConfig, 0)
 	for _, cfg := range c.KubernetesConversion {
 		if snapshots, ok := groupSnapshots[cfg.Group]; ok {

diff --git a/pkg/hook/controller/hook_controller.go b/pkg/hook/controller/hook_controller.go
@@ -322,6 +322,13 @@ func (hc *hookController) getIncludeSnapshotsFrom(bindingType BindingType, bindi
 				break
 			}
 		}
+	case KubernetesMutating:
+		for _, binding := range hc.mutatingBindings {
+			if bindingName == binding.BindingName {
+				includeSnapshotsFrom = binding.IncludeSnapshotsFrom
+				break
+			}
+		}
 	case KubernetesConversion:
 		for _, binding := range hc.conversionBindings {
 			if bindingName == binding.BindingName {