Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix: increase email field length in email_tokens #4125

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

DavideIadeluca
Copy link
Contributor

Fixes #0000
#4118 (review)

Changes proposed in this pull request:
The change done in #4117 to increase the email field length is incomplete, as the email field in the email_tokens table needs to be adjusted as well (see #4118 (review))

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title fix: increase email field length in email_tokens as well fix: increase email field length in email_tokens Nov 22, 2024
@DavideIadeluca DavideIadeluca changed the title fix: increase email field length in email_tokens [1.x] fix: increase email field length in email_tokens Nov 22, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 22, 2024 10:07
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 22, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants