Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recover support for ico favicon #4126

Merged
merged 2 commits into from
Nov 22, 2024
Merged

feat: recover support for ico favicon #4126

merged 2 commits into from
Nov 22, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 22, 2024

Fixes flarum/issue-archive#73

Changes proposed in this pull request:

  • Recovers the lost support for ico favicon uploads
  • Improves extensibility of the abstract UploadImageController controller

@SychO9 SychO9 requested a review from a team as a code owner November 22, 2024 13:01
@SychO9 SychO9 changed the title Sm/ico uploads feat: recover support for ico favicon Nov 22, 2024
@SychO9 SychO9 added this to the 2.0 milestone Nov 22, 2024
@SychO9 SychO9 merged commit 41e5ff2 into 2.x Nov 22, 2024
28 checks passed
@SychO9 SychO9 deleted the sm/ico-uploads branch November 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't upload ico favicons
2 participants