Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
metachris committed Jun 1, 2024
1 parent a6b8575 commit 93defa8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions docs/adrs/202405-bidcollect.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Run:
go run . service bidcollect --out csv --data-api --ultrasound-stream
```

#### Done
### Done

- Ultrasound bid stream
- Data API polling
Expand All @@ -31,15 +31,15 @@ go run . service bidcollect --out csv --data-api --ultrasound-stream
- Writing to csv for top and all bids
- Cache for deduplication

#### Next up (must have)
### Next up (must have)

- Diagram showing the flow of data and the components involved
- File Output
- Combine all individual files into a big file
- Consider gzipped CSV output: https://gist.github.com/mchirico/6147687 (currently, an hour of bids is about 300MB)
- Consider Parquet output files

#### Could have
### Could have

**Data API polling**
- consider improvements to timing
Expand Down
2 changes: 1 addition & 1 deletion services/bidcollect/data-api-poller.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (poller *DataAPIPoller) pollRelaysForBids(slot uint64, t int64) {

// Poll for bids now
untilSlot := tSlotStart.Sub(time.Now().UTC())
poller.Log.Debugf("[data-api poller] polling for slot %d at %d (tNow=%s)", slot, t, untilSlot.String())
poller.Log.Debugf("[data-api poller] polling for slot %d at t=%d (tNow=%s)", slot, t, (untilSlot * -1).String())

for _, relay := range poller.Relays {
go poller._pollRelayForBids(slot, relay, t)
Expand Down

0 comments on commit 93defa8

Please sign in to comment.