Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support read Genesis from env for custom chain #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support read Genesis from env for custom chain #57

wants to merge 2 commits into from

Conversation

ohko4711
Copy link

📝 Summary

close: #56

⛱ Motivation and Context

📚 References

✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

metachris
metachris reviewed Nov 27, 2024
View reviewed changes
vars/vars.go Outdated Show resolved Hide resolved
@metachris
Copy link
Contributor

nice, thanks! left a comment.

@ohko4711
Copy link
Author

nice, thanks! left a comment.

@metachris fixed

metachris
metachris approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ohko4711
Copy link
Author

@metachris Lint is unrelated to this PR. Can we merge and close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metachris metachris metachris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest var:Genesis reading from environment variables to support custom chains.
2 participants
@ohko4711 @metachris