Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for Proxy Protocol #125

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

danny-cheung
Copy link
Contributor

No description provided.

@danny-cheung
Copy link
Contributor Author

@flashmob
Could you please

  • Re-run the latest that CI build. Some random flake crept into one of the jobs.
  • Review the PR

@danny-cheung
Copy link
Contributor Author

danny-cheung commented Nov 19, 2018

@flashmob When would you have some time to look at this PR?

@flashmob
Copy link
Owner

flashmob commented Jan 6, 2019

Hi, thanks for your interest in contributing.

Is there an RFC or official spec that this PR is implementing?

@danny-cheung
Copy link
Contributor Author

@dekimsey
Copy link

This is only going to include PROXY v1, there's a v2. Might be worth using a library like https://github.com/pires/go-proxyproto instead to do the heavy lifting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants