Update ares to v143

[BlueInterlude]

• Update ares to v143
  • Updated buildsystem:
    • Added cmake-ninja to build ares
    • Added module to build Librashader
    • Added module to download shaders from libretro
    • Added module to install the metainfo file
  • Added README with instructions on how to update the cargo-sources.json file for Librashader
  • Added ares-paths.patch to temporarily fix Flatpak not locating the database or shaders folders
    • Working with upstream ares developers for a better resolution, until then use this patch file. Upstream PR: nall: Retrieve executable path more reliably ares-emulator/ares#1844. Can remove this patch next ares version.

Supercedes #43, #51 and #55

Closes #36, #49, #50, and #52

EDIT:

• Add another PR to supercedes by @ghisvail

[flathubbot]

Started test build 181719

[flathubbot]

Build 181719 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164908/dev.ares.ares.flatpakref

[BlueInterlude]

@ghisvail

Since the ares Flatpak v142 has some broken functionality (everything that uses the database folder doesn't work, including NES and SNES games) along with shaders not working, it'd be good to either temporarily revert the Flatpak to 141 or review and get this PR merged.

[flathubbot]

Started test build 181729

[flathubbot]

Build 181729 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164923/dev.ares.ares.flatpakref

[flathubbot]

Started test build 181731

[flathubbot]

Build 181731 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164925/dev.ares.ares.flatpakref

[flathubbot]

Started test build 181734

[flathubbot]

Build 181734 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164928/dev.ares.ares.flatpakref

[flathubbot]

Started test build 181735

[flathubbot]

Build 181735 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164929/dev.ares.ares.flatpakref

[flathubbot]

Started test build 181759

[flathubbot]

Build 181759 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164953/dev.ares.ares.flatpakref

[ghisvail]

The diff issue on the manifest file needs fixing to finalize the review.

[ghisvail]

This branch also needs rebasing.

[ghisvail]

Thanks for looking into it and giving detailed explanations of what's going on. Very much appreciated.

[BlueInterlude]

Thanks for looking into it and giving detailed explanations of what's going on. Very much appreciated.

No problem! Should be good to go now.

[flathubbot]

Started test build 181855

[flathubbot]

Build 181855 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/165050/dev.ares.ares.flatpakref

[Mastergatto]

For this flatpak I suggest to pick also this commit ares-emulator/ares@54c898f that fixes a serious bug in v143 affecting game saves.

[BlueInterlude]

For this flatpak I suggest to pick also this commit ares-emulator/ares@54c898f that fixes a serious bug in v143 affecting game saves.

Thank you for the heads up! I updated the manifest to point to that commit instead.

[flathubbot]

Started test build 181904

[flathubbot]

Build 181904 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/165100/dev.ares.ares.flatpakref

[ghisvail]

I would like this PR to stick to what's required to update to v143.

What @Mastergatto suggested should eventually go to a separate PR following this one, and only include the patch corresponding to the commit.

In general, it is bad practice to package git snapshots since other features in development may still be in flux and not considered stable yet. So either we wait for v144 or include the patch corresponding to 54c898f. That being said if this fix is that serious, it should be a good reason to convince upstream to release a new stable version.

[ghisvail]

Other than reverting the source for ares to stable archives, LGTM.

[flathubbot]

Started test build 182088

[flathubbot]

Build 182088 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/165285/dev.ares.ares.flatpakref