Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add io.sourceforge.atanks #3449

Open
wants to merge 3 commits into
base: new-pr
Choose a base branch
from
Open

Add io.sourceforge.atanks #3449

wants to merge 3 commits into from

Conversation

Mailaender
Copy link

Deprecate flathub/net.sourceforge.atanks#8 as upstream changed the application ID as SourceForge changed their URLs.

@Mailaender
Copy link
Author

bot, build io.sourceforge.atanks

@flathubbot
Copy link

Queued test build for io.sourceforge.atanks.

@flathubbot
Copy link

Started test build 107136

@flathubbot
Copy link

Build 107136 failed

@Mailaender
Copy link
Author

bot, build io.sourceforge.atanks

@flathubbot
Copy link

Queued test build for io.sourceforge.atanks.

@flathubbot
Copy link

Started test build 107140

@flathubbot
Copy link

Build 107140 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104812/io.sourceforge.atanks.flatpakref

@barthalion @hfiguiere
Update runtime to 22.08
72e4d50 
Co-authored-by: Hubert Figuière <[email protected]>
@barthalion
Copy link
Member

bot, build io.sourceforge.atanks

@flathubbot
Copy link

Queued test build for io.sourceforge.atanks.

@barthalion
Copy link
Member

I don't think it makes sense to rename the app only because Sourceforge changed its domain. Renaming is generally pretty disruptive process so we tend to avoid it unless the app is maintained by upstream.

@flathubbot
Copy link

Started test build 107636

@flathubbot
Copy link

Build 107636 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105304/io.sourceforge.atanks.flatpakref

@Mailaender
Copy link
Author

Upstream changed the name in their metainfo file and as per policy this is maintained by them it leaves you no choice.

@hfiguiere
Copy link
Contributor

rename-appdata-file will actually take care of it.

@hfiguiere
Copy link
Contributor

it leave all the choice, including patching.

@Mailaender
Copy link
Author

I think that should be disallowed via @flathub guidelines.

@hfiguiere hfiguiere added the blocked Pull requests that are blocked on something or won't be accepted in the currrent state label Aug 9, 2023
@bbhtt bbhtt changed the title Add Atomic Tanks again under new ID Add io.sourceforge.atanks May 11, 2024
@bbhtt bbhtt added the migrate-app-id Migrate an application to a new app-id label May 11, 2024
@hfiguiere hfiguiere mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfiguiere hfiguiere hfiguiere left review comments

Assignees
No one assigned
Labels
blocked Pull requests that are blocked on something or won't be accepted in the currrent state migrate-app-id Migrate an application to a new app-id
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mailaender @flathubbot @barthalion @hfiguiere @bbhtt