Global Menus Support

[rangelovd]

Connects Session Bus to Global Menu.
Fixes #127

[flathubbot]

Started test build 107372

[flathubbot]

Build 107372 failed

[Jehan]

bot, build

[flathubbot]

Queued test build for org.gimp.GIMP.

[flathubbot]

Started test build 115244

[flathubbot]

Build 115244 failed

[Jehan]

Apparently there is again a permission issue, though it's a bit weird. The new permission we request is com.canonical.AppMenu.Registrar and the cid-missing-affiliation-gnome say we are using the project_group tag (we are not, I've double-checked the manifest).
Looks like a mixup.

@hfiguiere You are good with these permission novelties. You know what's up?

flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo
 in dir /srv/buildbot/worker/build-x86_64-4/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo'
 using PTY: False
{
    "errors": [
        "appstream-failed-validation"
    ],
    "warnings": [
        "appstream-name-too-long"
    ],
    "appstream": [
        "E: org.gimp.GIMP:3: cid-missing-affiliation-gnome org.gimp.GIMP"
    ],
    "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
}

[hfiguiere]

you didn't rebase the PR. fixes won't just appear by miracle.

[Jehan]

Ah.

[Jehan]

bot, build

[flathubbot]

Queued test build for org.gimp.GIMP.

[Jehan]

@rangelovd and @vroger11 Once the test build succeeds (hoping it does), could you please test it and confirm me that the test flatpak does work with global menu? I will only merge once I get test confirmation. Thanks!

[flathubbot]

Started test build 115350

[flathubbot]

Build 115350 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/98164/org.gimp.GIMP.flatpakref

[vroger11]

Hi, sorry I am a bit late I got,
error: Can't load uri https://dl.flathub.org/build-repo/98164/org.gimp.GIMP.flatpakref: Server returned status 404
So i could not test it :/

[Jehan]

bot, build

[flathubbot]

Queued test build for org.gimp.GIMP.

[flathubbot]

Started test build 117280

[flathubbot]

Build 117280 was cancelled

[flathubbot]

Started test build 117281

[Jehan]

@vroger11 Yes the test build artifacts are only alive a few days. I just restarted a test build. When it's finished, the bot will again comment with a command line to run. Could you test then?

[flathubbot]

Build 117281 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/100106/org.gimp.GIMP.flatpakref

[vroger11]

Sadly, it does not work, I get this in the terminal:
Gtk-Message: 17:49:58.965: Failed to load module "appmenu-gtk-module"

[Jehan]

@vroger11 Just to be sure, how did you run this flatpak? In particular, from command line, you should be able to run it with:

flatpak run org.gimp.GIMP//test

Basically if you have the stable and/or beta flatpak installed and you just run from menus or the like, I'm unsure which flatpak will run (well it is in fact verifiable, but running with the //test suffix is just as good).

If this is really the correct test flatpak you ran and it doesn't work, I don't know. Further patches welcome. I personally have no idea how to fix this.

[Jehan]

P.S.: thanks for testing by the way, @vroger11 !

[vroger11]

It is normal, I used flatpak run org.gimp.GIMP (I have only the test branch installed). And flatpak run org.gimp.GIMP//test gives me the same result.

[Jehan]

Well if you only have this branch installed, flatpak run org.gimp.GIMP is the same of course. It's only when you have several branch installed that you can't be completely sure which one is run by default (you in fact can with flatpak make-current command, which was the other method I was mentioning).

Anyway too bad it didn't work. Let's see if @rangelovd knows a better solution.

[brunvonlope]

Considering what I researched and described in https://gitlab.gnome.org/GNOME/gimp/-/issues/7371#note_2054303, this MR is probably flawed by design and maybe will never implement global menus successfully. Quoting:

For summarize, the old global menu concept isn't supported at all in KWin using Wayland. See: https://bugs.kde.org/show_bug.cgi?id=424485. A protocol was proposed but rejected by Freedesktop (then replaced by this proposition) and considering that GNOME Shell itself dropped the support to global menus, only with brute force of the KDE contributors that this can fixed in KDE side, which hasn't happened yet.

[brunvonlope]

Converting to draft as per: #288 (comment)