builder-manifest: Report the index of the module with the missing name #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingPing
reviewed
Dec 27, 2022
| g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, | ||
| "Module has no 'name' attribute set"); | ||
| "The %lu. Module has no 'name' attribute set", i); |
There was a problem hiding this comment.
This phrasing is odd "The 3. Module has no...".
Maybe "Module (3) has no..."
However I have another concern which is that this isn't helpful for any manifest with submodules, as it will point you in the wrong place.
There was a problem hiding this comment.
If I'm not mistaken the . after the number is the German equivalent of th in English.
There was a problem hiding this comment.
@hfiguiere Yeah, that's right I'm from Austria and we use the . over here.
Unfortunately, I'm pretty busy for the next month, and it will take some time until I can try to fix the problem with the submodules and the bad grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help the user identify the broken module more easily.