FOGL-6891: Handle storage service restart #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amandeep Singh Arora <[email protected]>
Signed-off-by: Amandeep Singh Arora <[email protected]>
MarkRiddoch
requested changes
Dec 2, 2022
There was a problem hiding this comment.
The unit tests are failing and need to be addressed.
I see a number of #if 1 and #if 0 blocks that make this look like experimental code. We should either indicate why the alternatives are there or remove them if it was experimental code.
The code is littered with PRINT_FUNC, is this a debugging aid of yours? Is it needed or intended to be included in the code?
| @@ -79,6 +80,43 @@ NotificationService::~NotificationService() | |||
| delete m_logger; | |||
| } | |||
|
|
|||
| bool NotificationService::connectToStorage(std::map<std::thread::id, std::atomic<int>>* m) | |||
There was a problem hiding this comment.
Please add doxygen header comment
| if (getStorageServiceRestartPendingFlag()) | ||
| { | ||
| PRINT_FUNC; | ||
| #if 1 |
There was a problem hiding this comment.
Do we need this? If so add something that is more descriptive than if 1
| #endif | ||
| PRINT_FUNC; | ||
|
|
||
| #if 0 |
There was a problem hiding this comment.
Likewise, if it is obsolete remove it or if it has h=use use a descriptive #if
|
|
||
| PRINT_FUNC; | ||
|
|
||
| #if 0 |
| PRINT_FUNC; | ||
| #endif | ||
|
|
||
| #if 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage service restart is handled in notification service. But this hasn't been tested a lot. Also lots of debug logs are still present in this current code.