Handling of singed int of protobuf payload #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwini Kumar Pandey <[email protected]>
| @@ -297,13 +297,17 @@ def on_message(self, client, userdata, msg): | |||
| device_readings = {} | |||
| for metric in sparkplug_payload.metrics: | |||
| value = "Unknown" | |||
| data_type = metric.datatype | |||
There was a problem hiding this comment.
Should we check has field data_type?
If missing is that an error and should be logged?
| if metric.HasField("boolean_value"): | ||
| """ bool value cast to int as internal. See FOGL-8067 """ | ||
| value = metric.boolean_value | ||
| elif metric.HasField("float_value"): | ||
| value = metric.float_value | ||
| elif metric.HasField("int_value"): | ||
| value = metric.int_value | ||
| if data_type < 5 : |
There was a problem hiding this comment.
Why <5
We should have some inline comment explaining this.
|
For smaller than the minimum value (-2147483648) of a signed 32-bit integer say -2147483649, it ingests the max value of signed 32-int i.e. 2147483647. |
Signed-off-by: ashwini-k-pandey <[email protected]>
Signed-off-by: ashwini-k-pandey <[email protected]>
ashwini-k-pandey
changed the title
firozalikhan
approved these changes
Jan 7, 2025
praveen-garg
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.